repair gparm output to adjust for -VBK change#769
Merged
Conversation
Collaborator
Author
|
@e-perl-NOAA Add this PR to the 3.30.25 prerelease |
e-perl-NOAA
approved these changes
Jun 25, 2026
e-perl-NOAA
left a comment
e-perl-NOAA
left a comment
Collaborator
There was a problem hiding this comment.
I'll trust your math on this one @Rick-Methot-NOAA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concisely describe what has been changed/addressed in the pull request.
The restores correct output of VBK and t0 to the growth_parameter output. Incorrect output was occurring due to the change of sign to VBK in 3.30.25.
What tests have been done?
eyeball the output
Where are the relevant files?
<-- - [x] No test files are required for this pull request. -->
What tests/review still need to be done?
none
Is there an input change for users to Stock Synthesis?
Additional information (optional).